Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Epoch Sync] Enable epoch sync by default in configs. #12352

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

robin-near
Copy link
Contributor

The previous config defaulted to false, which is not good, because we want all nodes to default it to true. This change renames the fields to "disable_..." because (1) we need a field name change to apply new defaults because some nodes may already have reinitialized the config; (2) defaulting a field to false is more natural and less error-prone, so using "disable" rather than "enable" will more naturally default to enabling.

Also document the config fields.

Closes #12347

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.19%. Comparing base (8e30ccd) to head (a7ef45f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12352      +/-   ##
==========================================
- Coverage   71.19%   71.19%   -0.01%     
==========================================
  Files         839      839              
  Lines      169743   169744       +1     
  Branches   169743   169744       +1     
==========================================
- Hits       120851   120843       -8     
- Misses      43633    43645      +12     
+ Partials     5259     5256       -3     
Flag Coverage Δ
backward-compatibility 0.16% <0.00%> (ø)
db-migration 0.16% <0.00%> (ø)
genesis-check 1.22% <66.66%> (+<0.01%) ⬆️
integration-tests 38.97% <100.00%> (-0.03%) ⬇️
linux 70.64% <100.00%> (-0.01%) ⬇️
linux-nightly 70.76% <100.00%> (-0.02%) ⬇️
macos 50.41% <100.00%> (-0.01%) ⬇️
pytests 1.54% <66.66%> (+<0.01%) ⬆️
sanity-checks 1.34% <66.66%> (+<0.01%) ⬆️
unittests 64.16% <100.00%> (+<0.01%) ⬆️
upgradability 0.21% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robin-near robin-near added this pull request to the merge queue Oct 31, 2024
Merged via the queue into near:master with commit e4e9125 Oct 31, 2024
28 of 29 checks passed
@robin-near robin-near deleted the esync17 branch October 31, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Epoch Sync] Enable epoch sync config by default
2 participants