[Epoch Sync] Enable epoch sync by default in configs. #12352
Merged
+24
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreyan-gupta
approved these changes
Oct 30, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12352 +/- ##
==========================================
- Coverage 71.19% 71.19% -0.01%
==========================================
Files 839 839
Lines 169743 169744 +1
Branches 169743 169744 +1
==========================================
- Hits 120851 120843 -8
- Misses 43633 43645 +12
+ Partials 5259 5256 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous config defaulted to false, which is not good, because we want all nodes to default it to true. This change renames the fields to "disable_..." because (1) we need a field name change to apply new defaults because some nodes may already have reinitialized the config; (2) defaulting a field to false is more natural and less error-prone, so using "disable" rather than "enable" will more naturally default to enabling.
Also document the config fields.
Closes #12347